Differential D4327

Remove remnants of PACKAGERS_BUILD option
ClosedPublic
Actions

Authored by nicholasl on Jan 29 2017, 12:03 AM.

Details

Reviewers

rempt

Group Reviewers

Krita

Commits

R37:bf7e7db4e8aa: Remove remnants of PACKAGERS_BUILD option

Summary

After the option was removed in R37:a46bc0f05f8b2ee10878ea1a1e88e312c93b3ca8, Krita would segfault at startup for me. This patch fixes that and removes other references to PACKAGERS_BUILD.

(In a response to a bug report, Boud had said that the option was also removed in the 3.1 branch. However, the option is still there at the moment. Is there anything I should do about 3.1?)

Diff Detail

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicholasl updated this revision to Diff 10664.Jan 29 2017, 12:03 AM

nicholasl retitled this revision from to Remove remnants of PACKAGERS_BUILD option.

nicholasl updated this object.

nicholasl edited the test plan for this revision. (Show Details)

nicholasl added a reviewer: Krita.

nicholasl set the repository for this revision to R37 Krita.

Yes, I was wrong when I thought I had also removed it in 3.1. It might be a good idea to also remove it in 3.1. Please go ahead and push this to master. If you want to take a look at removing it from 3.1, don't hesitate :-)

This revision is now accepted and ready to land.Jan 30 2017, 9:14 AM

Closed by commit R37:bf7e7db4e8aa: Remove remnants of PACKAGERS_BUILD option (authored by nicholasl). · Explain WhyJan 30 2017, 12:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			README_PACKAGERS.md (2 lines)
M			libs/image/CMakeLists.txt (3 lines)
M			packaging/linux/appimage/build-krita.sh (1 line)
M			packaging/linux/appimage/build-release.sh (1 line)
M			packaging/osx/notes.txt (2 lines)
M			packaging/osx/run-cmake-krita.sh (1 line)
M			packaging/windows/build.bat (2 lines)
M			packaging/windows/build_krita.bat (2 lines)
M			packaging/windows/mxe.txt (2 lines)