Don't force queries and repositories through PageModel ctor
ClosedPublic
Actions

Authored by ervin on Oct 14 2015, 7:56 PM.

Details

Reviewers

bensi
franckarrecot

Commits

R4:2953f061cd62: Don't force queries and repositories through PageModel ctor

Summary

It never made really sense to force that since that was injecting
details about tasks in potentially pure notes pages and vice versa. It
was assuming all pages being allowed to mix both tasks and notes, but
we're moving away from that.

Diff Detail

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin updated this revision to Diff 984.Oct 14 2015, 7:56 PM

ervin retitled this revision from to Don't force queries and repositories through PageModel ctor.

ervin updated this object.

ervin edited the test plan for this revision. (Show Details)

ervin added reviewers: bensi, franckarrecot.

bensi accepted this revision.Oct 15 2015, 11:52 AM

bensi edited edge metadata.

This revision is now accepted and ready to land.Oct 15 2015, 11:52 AM

Closed by commit R4:2953f061cd62: Don't force queries and repositories through PageModel ctor (authored by ervin). · Explain WhyOct 15 2015, 12:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/presentation/availabletaskpagesmodel.cpp (3 lines)
M			src/presentation/contextpagemodel.h (4 lines)
M			src/presentation/contextpagemodel.cpp (16 lines)
M			src/presentation/inboxpagemodel.h (6 lines)
M			src/presentation/inboxpagemodel.cpp (24 lines)
M			src/presentation/pagemodel.h (20 lines)
M			src/presentation/pagemodel.cpp (26 lines)
M			src/presentation/projectpagemodel.h (7 lines)
M			src/presentation/projectpagemodel.cpp (22 lines)
M			src/presentation/tagpagemodel.h (6 lines)
M			src/presentation/tagpagemodel.cpp (20 lines)
M			src/presentation/workdaypagemodel.h (7 lines)
M			src/presentation/workdaypagemodel.cpp (18 lines)
M			tests/units/presentation/contextpagemodeltest.cpp (43 lines)
M			tests/units/presentation/pagemodeltest.cpp (7 lines)
M			tests/units/presentation/workdaypagemodeltest.cpp (15 lines)