Sheets: Fix cell borders lost on save/load
ClosedPublic

Authored by danders on Jan 18 2017, 10:34 AM.

Details

Summary

The borders (and other style attributes) where sometimes lost when a style was composed:
When a NamedStyleKey substyle where encounter the style was cleared
loosing all already loaded substyles. As the NamedStyleKey substyle can appear in any position
in the list the loss was random.

Fixes T5086

Fixed-in: 3.0.1

Test Plan

Create a doc with cell borders.
Save/load
All cell borders should always be displayed.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
danders updated this revision to Diff 10311.Jan 18 2017, 10:34 AM
danders retitled this revision from to Sheets: Fix cell borders lost on save/load.
danders updated this object.
danders edited the test plan for this revision. (Show Details)
danders added a reviewer: mecir.
Restricted Application added projects: KEXI, Calligra: 3.0. · View Herald TranscriptJan 18 2017, 10:34 AM
mecir accepted this revision.Jan 29 2017, 4:16 PM
mecir edited edge metadata.

Looks good, thanks. Maybe clean those commented out debugging lines if they aren't needed anymore, but fine either way.

This revision is now accepted and ready to land.Jan 29 2017, 4:16 PM
This revision was automatically updated to reflect the committed changes.