Differential D402

Updated CMakeLists.txt to require Qt 5.5
AbandonedPublic
Actions

Authored by obogdan on Oct 12 2015, 1:08 PM.

Details

Reviewers
None
Group Reviewers
KDevelop
Summary

We are already using some specific QString functions available only in Qt 5.5, so this seems like a reasonable change.

Diff Detail

Repository
R32 KDevelop
Lint
Lint Skipped
Unit
Unit Tests Skipped
obogdan updated this revision to Diff 965.Oct 12 2015, 1:08 PM
obogdan retitled this revision from to Updated CMakeLists.txt to require Qt 5.5.
obogdan updated this object.
obogdan edited the test plan for this revision. (Show Details)
obogdan added a reviewer: KDevelop.
obogdan set the repository for this revision to R32 KDevelop.
obogdan added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 12 2015, 1:08 PM
obogdan added a comment.Oct 12 2015, 3:02 PM

Currently if Qt 5.5 is not available KDevelop build fails with:

documentation/qthelp/qthelpdocumentation.cpp:68:69: error: no matching function for call to ‘QString::indexOf(const QRegularExpression&, int, QRegularExpressionMatch*) const’
     int pos = dataString.indexOf(findFragment, 0, &findFragmentMatch);
mwolff added a subscriber: mwolff.Oct 12 2015, 3:22 PM

I'd rather the function be rewritten to make it work with 5.4.0, it's not hard.

obogdan abandoned this revision.Oct 12 2015, 3:32 PM

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 965

View Options

CMakeLists.txt

Loading...