Differential D3752

Fix crash when attempting to use a document that has a 16-bit float XYZ color space
ClosedPublic
Actions

Authored by nicholasl on Dec 20 2016, 6:24 AM.

Details

Reviewers
rempt
Group Reviewers
Krita: Stable bug fixes
Commits
R37:780de3425f33: Fix crash when attempting to use a document that has a 16-bit float XYZ color…
R37:aa6c415e4aab: Fix crash when attempting to use a document that has a 16-bit float XYZ color…
Summary

XyzF16ColorSpace::colorDepthId() would return Float32BitsColorDepthID. This caused Krita to segfault when you created a document using the XYZ color model with 16-bit float depth.
It was possible to convert a layer to use the same properties, but an assertion would fail when trying to reopen it.

krita.lib.pigment: No path from  "XYZA F32 XYZ identity built-in"  to  "XYZA F32 XYZ identity built-in"  found not 
Segmentation fault (core dumped)
ASSERT (krita): "m_colorSpace->pixelSize() == dstColorSpace->pixelSize()" in file libs/image/kis_paint_device_data.h, line 131

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicholasl updated this revision to Diff 9203.Dec 20 2016, 6:24 AM
nicholasl retitled this revision from to Fix crash when attempting to use a document that has a 16-bit float XYZ color space.
nicholasl updated this object.
nicholasl edited the test plan for this revision. (Show Details)
nicholasl added a reviewer: Krita: Stable bug fixes.
rempt accepted this revision.Dec 20 2016, 10:28 AM
rempt added a reviewer: rempt.
This revision is now accepted and ready to land.Dec 20 2016, 10:28 AM
Closed by commit R37:780de3425f33: Fix crash when attempting to use a document that has a 16-bit float XYZ color… (authored by nicholasl). · Explain WhyDec 20 2016, 9:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 9236

View Options

plugins/color/lcms2engine/colorspaces/xyz_f16/XyzF16ColorSpace.h

Loading...