- body in method
- objectspec in file
- ready to create pretty code generator
Details
Details
- Reviewers
jangmarker pavelvasev
Diff Detail
Diff Detail
- Repository
- R18 QMLWeb
- Branch
- feature/revampIR
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Looks good, generally :)
You should delete the commented out code and please move the definition of the methods to the cpp, before we merge, though.
| src/qmljsc/ir/objecttree.h | ||
|---|---|---|
| 45 | We actually don't need it, so we should remove it. :) | |
| 99 | (besides the fact, that they should be moved to the cpp file ;) ) kdelibs coding style (which we stick to) sais, that you shall write the braces in a new line, if it's about functions (and in the same line for if, while, etc.) | |
| src/qmljsc/ir/typesystem.h | ||
| 90 | use one space instead of two here :) | |
| 142 | Why do you add a commented out line? :D | |
| tests/auto/qmljsc/testir.cpp | ||
| 166 | Don't comment out, but delete, please :) | |