Details
- Reviewers
jangmarker pavelvasev
Diff Detail
- Repository
- R18 QMLWeb
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Thanks for your work! :)
Don't worry about the long list of comments, when Jan does reviews to my code (or the other way around), the list isn't shorter ;)
src/qmljsc/ir/ir.cpp | ||
---|---|---|
36 | We should remove that, as well. | |
149 | commented out code | |
164 | ? | |
206 | Why are you commenting this out? | |
292 | If it doesn't make sense anymore, remove it :) | |
366 | if this accept method doesn't do anything different, than the method of the base class, then there's no reason to reimplement it ;) | |
387 | I think we can remove that as well :) | |
src/qmljsc/ir/ir.h | ||
87 | Please put the implementation into the cpp file. :) | |
106 | We should just delete that, rather than commenting it out. | |
125 | Same as above, we should delete it. | |
153 | We should not include outcommented code, so we should remove it for now. | |
162 | Please put the implementation into the cpp file. :) | |
172 | Please put the implementation into the cpp file. :) | |
182 | Please put the implementation into the cpp file. :D | |
197 | Please put the implementation into the cpp file. :) (Nooooo, I'm not copy&pasting that :D) | |
199 | you accidentially added a few whitespaces here ;) | |
227 | Please put the implementation into the cpp file. :) | |
257 | Please put the implementation into the cpp file. :) | |
272 | If you add a comment yourself, that this is bad, you shouldn't do it :) | |
277 | Please put the implementation into the cpp file. :) | |
300 | Why is class an object? | |
306 | Guess what :D | |
320 | I think we need Component to inherit from Object. But your implementation is much nearer to what we need, so let's just remove this :) | |
380 | Please put the implementation into the cpp file. :) | |
390 | we should keep dummy the last in the list | |
396 | No, this isn't the right approach here. If you need it as a polyfill until the QtQmlModuleLoader is available, please put it into prettygeneratorpass.cpp, for now. :) | |
430 | I think a boolean flag is enough and it seems you successfully implemented it with a boolean flag. So we can remove that code :) | |
436 | I think we must subclass it from Object, because the rootObject belongs to the Component-object, not to the class "Component". | |
448 | Please put the implementation into the cpp file. :) | |
473 | Yeah, you know, what to do :D |