| kfunk |
| KDevelop |
This patch fixes problems tooltips. Current version shows tooltips only for problems from built-in parser. New version provides:
Tested on master branch with kdev-cppcheck, kdev-valgrind, kdev-verapp plugins. All tested cases work correcttly:
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Rest LGTM, nice idea! Please update the patch, then I'll have another look.
| language/duchain/navigation/problemnavigationcontext.cpp | ||
|---|---|---|
| 85 | When sorting by multiple sort criterias I favor this pattern here: http://stackoverflow.com/a/3574724 Or, let's be fancy and use C++11 std::tie: http://stackoverflow.com/a/17080762 | |
| 118 | Shouldn't this method be called escapedHtml or something? | |
| 263–265 | .at(...) And you should assert that action != nullptr in that case then. No need for the else-branch. | |
| language/duchain/navigation/problemnavigationcontext.cpp | ||
|---|---|---|
| 85 | Fixed. Thanks for std::tie link, but it's impossible to use it for this case - it requires lvalues, but we have only rvalues :( | |