Details

Reviewers

Group Reviewers

Commits

R33:c98bc05e659b: Fix highlighting for problems with incomplete finalLocation
R32:08f7e619b0be: IProblem: move FinalLocationMode-methods implementation into subclasses to turn…
R33:08f7e619b0be: IProblem: move FinalLocationMode-methods implementation into subclasses to turn…
R32:c98bc05e659b: Fix highlighting for problems with incomplete finalLocation

Summary

This patch fixes highlighting for problems, which has incomplete finalLocation. Many checkers produce only line number in the log, which makes impossible to set correct range for problem without parsing of checked source file. To fix this case we adds LocationRangeMode methods which allows to control highlighting process for such problems.

Test Plan

Tested on master branch with kdev-cppcheck plugin.

Results (line 63):

Original (old) behavior, ugly 1-symbol highlighting

New (improved behavior, with TrimmedLine mode

Diff Detail

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

antonanikin updated this revision to Diff 7743.Oct 29 2016, 7:57 AM

antonanikin retitled this revision from to problem_location_mode.

antonanikin updated this object.

antonanikin edited the test plan for this revision. (Show Details)

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 29 2016, 7:57 AM

antonanikin retitled this revision from problem_location_mode to Fix highlighting for problems with incomplete finalLocation.Oct 29 2016, 8:05 AM

antonanikin updated this object.

antonanikin edited the test plan for this revision. (Show Details)

antonanikin added a reviewer: KDevelop.

small fixes

Codestyle fixes

Closed by commit R33:c98bc05e659b: Fix highlighting for problems with incomplete finalLocation (authored by antonanikin). · Explain WhyNov 2 2016, 8:10 AM

This revision was automatically updated to reflect the committed changes.

kfunk reopened this revision.Nov 2 2016, 8:23 AM

kfunk added a subscriber: kfunk.

kfunk added inline comments.

interfaces/iproblem.h
99	Please turn `IProblem` into a real interface again. You need to implement the methods in the subclasses.

Move new methods implementation into subclasses to turn IProblem into a real interface again.

antonanikin marked an inline comment as done.Nov 2 2016, 9:03 AM

kfunk requested changes to this revision.Nov 2 2016, 9:20 AM

kfunk added a reviewer: kfunk.

kfunk added inline comments.

language/duchain/problem.cpp
107	Better implement that properly as well. Just follow the way it's done for the other getters/setters.
111	Dito

This revision now requires changes to proceed.Nov 2 2016, 9:20 AM

Fix KDevelop::Problem

antonanikin marked 2 inline comments as done.Nov 2 2016, 9:35 AM

kfunk requested changes to this revision.Nov 2 2016, 9:51 AM

kfunk edited edge metadata.

kfunk added inline comments.

language/duchain/problem.cpp
112	Here: Look at `Problem::finalLocation` and `Problem::setFinalLocation` for inspiration.
language/duchain/problem.h
244	This needs to be in `ProblemData` instead. Sorry for not telling you in my earlier review ;)

This revision now requires changes to proceed.Nov 2 2016, 9:51 AM

Fix KDevelop::Problem

antonanikin marked an inline comment as done.Nov 2 2016, 10:24 AM

kfunk accepted this revision.Nov 2 2016, 12:18 PM

kfunk edited edge metadata.

This revision is now accepted and ready to land.Nov 2 2016, 12:18 PM

Closed by commit R33:08f7e619b0be: IProblem: move FinalLocationMode-methods implementation into subclasses to turn… (authored by antonanikin). · Explain WhyNov 2 2016, 12:52 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			interfaces/iproblem.h (13 lines)
M			language/duchain/problem.h (6 lines)
M			language/duchain/problem.cpp (11 lines)
M			shell/problem.h (3 lines)
M			shell/problem.cpp (13 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7743	bccdb75		Oct 29 2016, 7:57 AM	★	★
Diff 2	7744	bccdb75	small fixes	Oct 29 2016, 8:10 AM	★	★
Diff 3	7812	0accce1	- Codestyle fixes	Nov 2 2016, 7:53 AM	★	★
Diff 4	7813	0accce1	rKDEVPLATFORMc98bc05e659b54645ea6d2d5378d867b03eb5820	Nov 2 2016, 8:08 AM	★	★
Diff 5	7814	0accce1	- Move new methods implementation into subclasses to turn IProblem into a real interface again.	Nov 2 2016, 9:02 AM	★	★
Diff 6	7815	0accce1	- Fix KDevelop::Problem	Nov 2 2016, 9:32 AM	★	★
Diff 7	7816	0accce1	- Fix KDevelop::Problem	Nov 2 2016, 10:13 AM	★	★
Diff 8	7827	c98bc05	rKDEVPLATFORM08f7e619b0becbf021a7be2ad53ab53bce64f73f	Nov 2 2016, 12:51 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
b9a9876dacd3	d7c1457a1a84	078ddf672fdb	Anton Anikin	Fix KDevelop::Problem	Nov 2 2016, 10:12 AM
078ddf672fdb	03afa4becda1	8cbdabad4c9f	Anton Anikin	Fix KDevelop::Problem	Nov 2 2016, 9:29 AM
8cbdabad4c9f	67841042e929	77e3c9e33a7b	Anton Anikin	Move new methods implementation into sublasses to turn IProblem into a real… (Show More…)	Nov 2 2016, 9:02 AM
77e3c9e33a7b	d692bc4e7f90	0accce136675	Anton Anikin	Fix highlighting for problems with incomplete finalLocation (Show More…)	Nov 2 2016, 8:45 AM

Fix highlighting for problems with incomplete finalLocation
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 7827

interfaces/iproblem.h

language/duchain/problem.h

language/duchain/problem.cpp

shell/problem.h

shell/problem.cpp

Fix highlighting for problems with incomplete finalLocationClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 7827

interfaces/iproblem.h

language/duchain/problem.h

language/duchain/problem.cpp

shell/problem.h

shell/problem.cpp

Fix highlighting for problems with incomplete finalLocation
ClosedPublic
Actions

Revision Contents
Changeset List