Differential D3171

Add zsh support for kdevplatform konsole integration
ClosedPublic
Actions

Authored by octoploid on Oct 26 2016, 7:55 PM.

Details

Reviewers
kfunk
Commits
R33:e48231347a8d: Add zsh support for kdevplatform konsole integration
R32:e48231347a8d: Add zsh support for kdevplatform konsole integration
Summary

This patch adds zsh support for kdevplatform konsole integration.
An additional small patch for kdevelop is also necessary:
https://phabricator.kde.org/D3172

This diff is based on an very old patch from Philipp A.:
https://git.reviewboard.kde.org/r/110298/diff/4/

Test Plan

I've tested the patch locally and basic commands work fine under zsh.
Split open also works correctly.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
octoploid updated this revision to Diff 7681.Oct 26 2016, 7:55 PM
octoploid retitled this revision from to Add zsh support for kdevplatform konsole integration.
octoploid updated this object.
octoploid edited the test plan for this revision. (Show Details)
octoploid added a reviewer: kfunk.
octoploid set the repository for this revision to R33 KDevPlatform.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 26 2016, 7:55 PM
octoploid updated this object.Oct 26 2016, 8:00 PM
octoploid updated this object.
kfunk added inline comments.Oct 27 2016, 7:18 AM
util/CMakeLists.txt
57

I don't really like that we need to install that .zshrc file...

Is there really no other option to initialize zsh?

kfunk requested changes to this revision.Oct 27 2016, 7:27 AM
kfunk edited edge metadata.
This revision now requires changes to proceed.Oct 27 2016, 7:27 AM
octoploid added inline comments.Oct 27 2016, 7:33 AM
util/CMakeLists.txt
57

No, zsh doesn't support --init-file and loading .zshrc is hardcoded, so this is the only possible solution.

However I agree that installing it to ../bin is gross.
It could be installed into another directory. I'm open
to suggestions.

kfunk added inline comments.Oct 27 2016, 7:44 AM
util/CMakeLists.txt
57

Maybe install to ${SHARE_INSTALL_PREFIX}/kdevplatform/shellutils/, then reference the folder in kdevelop! like this: ../share/kdevplatform/shellutils/.

I think we can safely hardcode "share" here, SHARE_INSTALL_PREFIX is usually not modified...

octoploid updated this revision to Diff 7687.Oct 27 2016, 7:59 AM
octoploid edited edge metadata.

Change .zshrc install path

octoploid added a comment.Oct 31 2016, 1:39 PM

Ping? Can this be applied please.
Thanks.

kfunk accepted this revision.Nov 30 2016, 7:35 PM
kfunk edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2016, 7:35 PM
Closed by commit R33:e48231347a8d: Add zsh support for kdevplatform konsole integration (authored by kfunk). · Explain WhyNov 30 2016, 7:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMutil/.zshrc (2 lines)
Mutil/CMakeLists.txt (3 lines)
Mutil/kdevplatform_shell_environment.sh (88 lines)

Diff 8643

View Options

util/.zshrc

Loading...
View Options

util/CMakeLists.txt

Loading...
View Options

util/kdevplatform_shell_environment.sh

Loading...