Differential D3157

Add translation, remove unused code
ClosedPublic
Actions

Authored by pwojcik on Oct 25 2016, 5:27 PM.

Details

Reviewers
nienhueser
Group Reviewers
Marble
Commits
R34:52e0f546eae2: Add translation, remove unused code
R34:4cda53756805: Add translation, remove unused code
Summary

Take improvements back from Yours plugin

Test Plan

manually
no important changes, all works

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pwojcik updated this revision to Diff 7656.Oct 25 2016, 5:27 PM
pwojcik retitled this revision from to Add translation, remove unused code.
pwojcik updated this object.
pwojcik edited the test plan for this revision. (Show Details)
pwojcik added a reviewer: Marble.
pwojcik set the repository for this revision to R34 Marble.
pwojcik added a project: Marble.
pwojcik added a comment.Oct 25 2016, 5:37 PM

Suggestions about translatable string are welcome. Reference I used: http://www.routino.org/documentation/usage.html#H_1_1_2 parameter --transport

nienhueser accepted this revision.Nov 1 2016, 4:50 PM
nienhueser added a reviewer: nienhueser.
nienhueser added a subscriber: nienhueser.

Looks fine, I'll push it on your behalf.

This revision is now accepted and ready to land.Nov 1 2016, 4:50 PM
Closed by commit R34:52e0f546eae2: Add translation, remove unused code (authored by pwojcik, committed by nienhueser). · Explain WhyNov 1 2016, 4:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7805

View Options

src/plugins/runner/routino/RoutinoConfigWidget.ui

Loading...
View Options

src/plugins/runner/routino/RoutinoPlugin.h

Loading...
View Options

src/plugins/runner/routino/RoutinoPlugin.cpp

Loading...