Differential D315

DataSourceQueriesTest Porting to fake: shouldNotCrashDuringFindSearchChildrenWhenFetchJobFailedOrEmpty
ClosedPublic
Actions

Authored by franckarrecot on Aug 29 2015, 11:16 AM.

Details

Reviewers
bensi
ervin
remibenoit
Commits
R4:d810380b102b: DataSourceQueriesTest Porting to fake…

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
franckarrecot updated this revision to Diff 665.Aug 29 2015, 11:16 AM
franckarrecot retitled this revision from to DataSourceQueriesTest Porting to fake: shouldNotCrashDuringFindSearchChildrenWhenFetchJobFailedOrEmpty.
franckarrecot updated this object.
franckarrecot edited the test plan for this revision. (Show Details)
franckarrecot added reviewers: ervin, bensi, remibenoit.
ervin requested changes to this revision.Sep 2 2015, 5:50 PM
ervin edited edge metadata.
ervin added inline comments.
tests/units/akonadi/akonadidatasourcequeriestest.cpp
1192

s/fakeData/data/

1201

Right monitor!!!!! :-)

It's likely you don't need to keep the storage and monitor pointers around though.

1224

Where is the // WHEN gone?

This revision now requires changes to proceed.Sep 2 2015, 5:50 PM
franckarrecot updated this revision to Diff 729.Sep 5 2015, 11:48 AM
franckarrecot edited edge metadata.

o

ervin requested changes to this revision.Sep 5 2015, 4:26 PM
ervin edited edge metadata.
ervin added inline comments.
tests/units/akonadi/akonadidatasourcequeriestest.cpp
1200

No need for the GenCollection here.

This revision now requires changes to proceed.Sep 5 2015, 4:26 PM
franckarrecot updated this revision to Diff 761.Sep 6 2015, 11:49 AM
franckarrecot edited edge metadata.

o

ervin accepted this revision.Sep 6 2015, 2:05 PM
ervin edited edge metadata.
This revision is now accepted and ready to land.Sep 6 2015, 2:05 PM
Closed by commit R4:d810380b102b: DataSourceQueriesTest Porting to fake… (authored by franckarrecot). · Explain WhySep 7 2015, 8:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 813

View Options

tests/units/akonadi/akonadidatasourcequeriestest.cpp

Loading...