Differential D314

DataSourceQueriesTest Porting to fake: shouldReactToCollectionChangesForSearchChildSources
ClosedPublic
Actions

Authored by franckarrecot on Aug 29 2015, 11:16 AM.

Details

Reviewers
bensi
ervin
remibenoit
Commits
R4:5f6072d22533: DataSourceQueriesTest Porting to fake…

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
franckarrecot updated this revision to Diff 664.Aug 29 2015, 11:16 AM
franckarrecot retitled this revision from to DataSourceQueriesTest Porting to fake: shouldReactToCollectionChangesForSearchChildSources.
franckarrecot updated this object.
franckarrecot edited the test plan for this revision. (Show Details)
franckarrecot added reviewers: ervin, bensi, remibenoit.
ervin requested changes to this revision.Sep 4 2015, 7:27 PM
ervin edited edge metadata.
ervin added inline comments.
tests/units/akonadi/akonadidatasourcequeriestest.cpp
1126

s/fakeData/data/

1128–1129

s/childrend/children/
and I would say the "of parent" is redundent.

1137–1138

Wrong monitor

1155

Don't call it anymore, call data instead!

This revision now requires changes to proceed.Sep 4 2015, 7:27 PM
franckarrecot updated this revision to Diff 728.Sep 5 2015, 11:48 AM
franckarrecot edited edge metadata.

o

ervin requested changes to this revision.Sep 5 2015, 4:26 PM
ervin edited edge metadata.
ervin added inline comments.
tests/units/akonadi/akonadidatasourcequeriestest.cpp
1138

No need for the GenCollection here.

This revision now requires changes to proceed.Sep 5 2015, 4:26 PM
franckarrecot updated this revision to Diff 760.Sep 6 2015, 11:48 AM
franckarrecot edited edge metadata.

o

ervin accepted this revision.Sep 6 2015, 2:04 PM
ervin edited edge metadata.
This revision is now accepted and ready to land.Sep 6 2015, 2:04 PM
Closed by commit R4:5f6072d22533: DataSourceQueriesTest Porting to fake… (authored by franckarrecot). · Explain WhySep 7 2015, 8:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 812

View Options

tests/units/akonadi/akonadidatasourcequeriestest.cpp

Loading...