Differential D3134

Bring back usericon region selection
ClosedPublic
Actions

Authored by davidk on Oct 22 2016, 9:14 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R128:35715e6a5e22: Bring back usericon region selection
Summary

Also, improve error checking.

Test Plan
  • selected an new icon, got the region selector
  • without the resize, saving will fail for high resolution images
  • When resizing to a bigger size (e.g. 800x800 pixel), icons will be too big
  • Canceling the region selection will not change the icon

Diff Detail

Repository
R128 User Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidk updated this revision to Diff 7605.Oct 22 2016, 9:14 AM
davidk retitled this revision from to Bring back usericon region selection.
davidk updated this object.
davidk edited the test plan for this revision. (Show Details)
davidk added a reviewer: Plasma.
davidk added a subscriber: plasma-devel.
Restricted Application added a project: Plasma. · View Herald TranscriptOct 22 2016, 9:14 AM
davidk edited the test plan for this revision. (Show Details)Oct 22 2016, 9:20 AM
davidedmundson accepted this revision.Oct 23 2016, 5:02 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Oct 23 2016, 5:02 PM
Closed by commit R128:35715e6a5e22: Bring back usericon region selection (authored by davidk). · Explain WhyOct 25 2016, 7:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/accountinfo.cpp (12 lines)
Msrc/createavatarjob.cpp (23 lines)

Diff 7646

View Options

src/accountinfo.cpp

Loading...
View Options

src/createavatarjob.cpp

Loading...