| kfunk |
| KDevelop |
The patch fixes (random) order of tabs in ProblemsView with follows settings:
Tested on master branch. Manually plugin loading/unloading don't break the order.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Rest LGTM.
Please target 5.0 with this patch.
| plugins/problemreporter/problemsview.cpp | ||
|---|---|---|
| 438 | Hmm, I've just noticed an issue with the implementation of the whole problem model thingie. KDevelop::ProblemModelSet* pms = core()->languageController()->problemModelSet();
pms->addModel(QStringLiteral("Parser"), m_model);^ Here, "Parser" should be translated. In ProblemModelSet::addModel(const QString &name, ProblemModel *model) name acts both as an identifier + a human-readable string. This is wrong. We'd need to split this up and pass it both an id + the translated string. Fine for now, though, we can't change that in 5.0. | |
| 448 | Please add a comment why we're skipping the "Parser" tab. | |
| 451 | Please use http://doc.qt.io/qt-5/qstring.html#localeAwareCompare-1 instead | |
LGTM, please push to 5.0 branch though. Needs a rebase apparently since it doesn't apply there.