Differential D3122

Fix Debuggers Actions Text
ClosedPublic
Actions

Authored by antonanikin on Oct 20 2016, 10:21 AM.

Details

Reviewers

kfunk

Group Reviewers

KDevelop

Commits

R32:7fb0f3220df2: Fix Debuggers Actions Text

Summary

The patch fixes debuggers actions text when we have GDB and LLD plugins both enabled. This produce same text for both plugins and as a result we have 2 actions with text "Examine Core File..." and 2 with "Attach to Process...". This leads to user's impossibility to understand different between such actions.

Test Plan

Tested on mater branch

Diff Detail

Repository

R32 KDevelop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

antonanikin updated this revision to Diff 7566.Oct 20 2016, 10:21 AM

antonanikin retitled this revision from to Fix Debuggers Actions Text.

antonanikin updated this object.

antonanikin edited the test plan for this revision. (Show Details)

antonanikin added a reviewer: KDevelop.

antonanikin set the repository for this revision to R32 KDevelop.

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 20 2016, 10:21 AM

Rest LGTM, thanks!

debuggers/gdb/debuggerplugin.cpp
50	`i18n("GDB")`
debuggers/lldb/debuggerplugin.cpp
45	dito

This revision is now accepted and ready to land.Oct 20 2016, 10:40 AM

add i18n

antonanikin marked 2 inline comments as done.Oct 20 2016, 10:50 AM

Closed by commit R32:7fb0f3220df2: Fix Debuggers Actions Text (authored by antonanikin). · Explain WhyOct 20 2016, 10:51 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			debuggers/common/midebuggerplugin.h (4 lines)
M			debuggers/common/midebuggerplugin.cpp (10 lines)
M			debuggers/gdb/debuggerplugin.cpp (2 lines)
M			debuggers/lldb/debuggerplugin.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7566			Oct 20 2016, 10:17 AM	★	★
Diff 2	7567			Oct 20 2016, 10:49 AM	★	★
Diff 3	7568	c3fdef8	rKDEVELOP7fb0f3220df2f61895c14108b06b9cb61bce98a9	Oct 20 2016, 10:50 AM	★	★