Allow showing bicycle and foot routes with Yours service
ClosedPublic

Authored by pwojcik on Oct 19 2016, 5:39 PM.

Details

Test Plan

manually
car and bike options works
always got http 503 for foot

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pwojcik updated this revision to Diff 7553.Oct 19 2016, 5:39 PM
pwojcik retitled this revision from to Allow showing bicycle and foot routes with Yours service.
pwojcik updated this object.
pwojcik edited the test plan for this revision. (Show Details)
pwojcik set the repository for this revision to R34 Marble.
nienhueser added a project: Marble.

Looks good.

I can't get 'foot' running either. Seems to be a server-side issue, since other non-existing profiles (tried 'pedestrian' and 'walk') fall back to motorcar on the server side.

src/plugins/runner/yours/YoursPlugin.cpp
80

Should be doable with something like this:

QMap<QString, QString> transports;
transports["foot"] = tr("foot");
transports["bicycle"] = tr("bicycle");
transports["motorcar"] = tr("motorcar");
for(auto iter = transports.constBegin(); iter != transports.constEnd(); ++iter) {
    ui_configWidget->transport->addItem(iter.key(), iter.value());
}
src/plugins/runner/yours/YoursPlugin.h
19

I don't think this is needed.

pwojcik updated this revision to Diff 7594.Oct 21 2016, 1:04 PM

changes according to comments, also removed unused widgets from ui

nienhueser accepted this revision.Oct 21 2016, 8:50 PM
nienhueser added a reviewer: nienhueser.

Looks great, thanks. I'll push it on your behalf.

This revision is now accepted and ready to land.Oct 21 2016, 8:50 PM
This revision was automatically updated to reflect the committed changes.