The patch adds filtering UI for ProblemsView which is useful when we have a lot of problems - for example select Parser problem model and activate "Current Project" scope for big project (like kdevplatform).
BUG: 339839
kfunk |
KDevelop |
The patch adds filtering UI for ProblemsView which is useful when we have a lot of problems - for example select Parser problem model and activate "Current Project" scope for big project (like kdevplatform).
BUG: 339839
Tested on master branch.
UI before filtering:
UI after filtering:
UI before filtering (smaller edit size):
UI after filtering (smaller edit size):
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Hmm, I feel like this is cluttering this part of the UI even more without bringing a lot of gain. Personally I've never felt the urge to search in the problems view.
Maybe at least don't let the search box expand and give it a reasonable max size?
Other opinions?
Hmm, I feel like this is cluttering this part of the UI even more without bringing a lot of gain. Personally I've never felt the urge to search in the problems view.
I think it can be useful sometimes. For example we can search for some warning like "unused variable" in big projects through Parser problems model instead of rebuilding whole code.
Maybe at least don't let the search box expand and give it a reasonable max size?
Ok, I will fix it to smaller size.
I'd like to +1 for this change. We have a Feature request for it for some time now: https://bugs.kde.org/show_bug.cgi?id=339839
Bug: Filter isn't cleared when changing tabs inside the problems tool view. Please fix.
plugins/problemreporter/problemtreeview.cpp | ||
---|---|---|
158 | Prefer QRegularExpression |
Bug: Filter isn't cleared when changing tabs inside the problems tool view. Please fix.
@kfunk, fixed - now we drop the filter if tab is changed. It's trivial also to store personal search string for each tab if it seems to be interesting (reasonable).
plugins/problemreporter/problemtreeview.cpp | ||
---|---|---|
158 | Simplified |
Another issue:
Prereq:
Actual:
Expected:
Actual:
- Parser tab text stays at "Parser (2)" Expected:
- Parser tab text resets to "Parser (7)"
Yes, it's true. The reason - we drop filter for new (opened) tab, but not for previous. If we switch back - it will show (7). Ok, in next revision I'll fix it.
plugins/problemreporter/problemsview.cpp | ||
---|---|---|
211 | Thanks, I don't know about using lambdas together with this receiver. |