| kfunk |
| KDevelop |
The patch continues use-nullptr migration with changes for some parts of code which was not fixed by clang-tidy.
Unfortunately it's not possible now to enable "-Wzero-as-null-pointer-constant" flag without adding many ugly fixes to code. It causes by warnings/errors produced by this flag for 3rd-party, non-KDevelop code such a KF5, Qt which still use old-style zeroes instead nullptr.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| shell/tests/test_sessioncontroller.cpp | ||
|---|---|---|
| 97 ↗ | (On Diff #7464) | Without this (ugly) params we has warning/error with enabled "zero-as-null-pointer-constant" flag :( |
| sublime/tests/test_areaoperation.cpp | ||
| 198 ↗ | (On Diff #7464) | same as above. This is because of using zero for nullptr in external libs like KF5, Qt,... :( |
@antonanikin We should fix the external libs then -- I don't like adding boiler plate code in kdevplatform just to fix issues in external libs.
-Wzero-as-null-pointer-constant should not warn for "system" headers... Is that a GCC bug?
I don't like adding boiler plate code in kdevplatform just to fix issues in external libs.
+1, it's ugly
-Wzero-as-null-pointer-constant should not warn for "system" headers... Is that a GCC bug?
I don't know. But with gcc-6.2.1 this flag produce warnings/errors for such cases (includes).
As a result I suggest drop "-Wno-error=zero-as-null-pointer-constant" from patch and clean it from redundant lines.