Differential D3070

Julia compilation fixes
ClosedPublic
Actions

Authored by tcanabrava on Oct 16 2016, 9:35 AM.

Details

Reviewers
filipesaraiva
Group Reviewers
Cantor
Commits
R55:3ef0e7ba6396: Julia compilation fixes
Summary

While compilling master, a few failures regarding julia where raised
on my computer:

Scanning dependencies of target cantor_juliaserver
[ 16%] Building CXX object
src/backends/julia/juliaserver/CMakeFiles/cantor_juliaserver.dir/juliaserver.cpp.o
In file included from
/home/tcanabrava/Projects/kdesrc/cantor/src/backends/julia/juliaserver/juliaserver.cpp:22:0:
/usr/include/julia/julia.h:59:27: fatal error: julia_threads.h: No such
file or directory
#include <julia_threads.h>

^
compilation terminated.

Inspecting the FindJulia that's shipped with Cantor, the issue seemed
obvious to me: it doesn't tries to find LibJulia, nor it does add
the julia includes to the include_directories.

Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>

Diff Detail

Repository
R55 Cantor
Branch
fix_julia_compilation
Lint
No Linters Available
Unit
No Unit Test Coverage
tcanabrava updated this revision to Diff 7415.Oct 16 2016, 9:35 AM
tcanabrava retitled this revision from to Julia compilation fixes.
tcanabrava updated this object.
tcanabrava edited the test plan for this revision. (Show Details)
filipesaraiva added a reviewer: Cantor.Oct 21 2016, 1:38 AM
filipesaraiva added a project: Cantor.
filipesaraiva added a subscriber: Cantor.
filipesaraiva accepted this revision.Nov 1 2016, 1:07 PM
filipesaraiva added a reviewer: filipesaraiva.
filipesaraiva added a subscriber: filipesaraiva.

Hi @tcanabrava, I could not to replicate your errors, but please push it. If we have some problem we can revert it.
Thanks!

This revision is now accepted and ready to land.Nov 1 2016, 1:07 PM
tcanabrava added a comment.Nov 1 2016, 2:37 PM

uh - how could you compile if it didn't linked to the julia libraries?

filipesaraiva added a comment.Nov 6 2016, 1:46 AM

Well, really I don't know. :D
It worked for me and the original author.

So please, push your patch and close this revision before release freeze.

asemke added a subscriber: asemke.Nov 6 2016, 8:24 AM

I couldn't compile cantor with julia support on openSuse Leap with similar errors like mentioned by tcanabrava. It works fine with this patch now.

tcanabrava closed this revision.Nov 6 2016, 10:04 AM

pushed to master.

Revision Contents
Changeset List

Diff 7415

View Options

cmake/FindJulia.cmake

Loading...
View Options

src/backends/julia/CMakeLists.txt

Loading...
View Options

src/backends/julia/juliaserver/CMakeLists.txt

Loading...