Differential D3013

add "Analyze" group to ContextMenuExtension
ClosedPublic
Actions

Authored by antonanikin on Oct 11 2016, 7:24 AM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:d5055a3bf4bb: add "Analyze" group to ContextMenuExtension
R33:d5055a3bf4bb: add "Analyze" group to ContextMenuExtension
Summary

This patch adds new group to ContextMenuExtension for analyzer plugins. Current versions of "kdev-cppcheck" and "clang-tidy" plugins move theirs actions to common "ExtensionGroup" which produce ugly random order and leads to "clogging" this group when many analyzers plugins are enabled.

New version adds "Analyze with" submenu to context for editor and project items. I think it will be also reasonable to add "Analyze" item to main menu (after "Run" item for example) to avoid "clogging" of "Run" menu which is currently used by "kdev-cppcheck" and "clang-tidy" plugins.

Diff Detail

Repository
R33 KDevPlatform
Lint
Lint Skipped
Unit
Unit Tests Skipped
antonanikin updated this revision to Diff 7291.Oct 11 2016, 7:24 AM
antonanikin retitled this revision from to add "Analyze" group to ContextMenuExtension.
antonanikin updated this object.
antonanikin edited the test plan for this revision. (Show Details)
antonanikin added a reviewer: KDevelop.
antonanikin set the repository for this revision to R33 KDevPlatform.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 11 2016, 7:24 AM
coliveira added a subscriber: coliveira.Oct 11 2016, 10:41 PM

I liked very much this idea! Do you consider we should remove the icon from the actions on both plugins?

kfunk accepted this revision.Oct 11 2016, 10:59 PM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

Looks good to me.

This goes to master branch, correct?

interfaces/contextmenuextension.cpp
193 ↗(On Diff #7291)

Capitalize 'With'

plugins/projectmanagerview/projecttreeview.cpp
344 ↗(On Diff #7291)

Dito

This revision is now accepted and ready to land.Oct 11 2016, 10:59 PM
antonanikin updated this revision to Diff 7330.Oct 12 2016, 1:40 AM
antonanikin edited edge metadata.
antonanikin marked 2 inline comments as done.
antonanikin added a comment.EditedOct 12 2016, 1:43 AM

This goes to master branch, correct?

Yes, I will push it to master. Kevin, what are you think about "final step" - adding "Analyze" main menu item?

antonanikin added a comment.Oct 12 2016, 1:46 AM

Do you consider we should remove the icon from the actions on both plugins?

Yes, I updated the revision - now we have icon for the new "Analyze With" submenu. I'll remove icons from kdev-cppcheck actions after pushing this patch to master branch.

Closed by commit R33:d5055a3bf4bb: add "Analyze" group to ContextMenuExtension (authored by antonanikin). · Explain WhyOct 12 2016, 1:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7330

View Options

interfaces/contextmenuextension.h

Loading...
View Options

interfaces/contextmenuextension.cpp

Loading...
View Options

plugins/projectmanagerview/projecttreeview.cpp

Loading...