Differential D3010

Fix PgUp/PgDn on layer stack
ClosedPublic
Actions

Authored by nicholasl on Oct 10 2016, 4:53 PM.

Details

Reviewers
rempt
Group Reviewers
Krita: Stable bug fixes
Maniphest Tasks
T3888: Navigating the layer stack with PgUp/PgDn is broken
Commits
R37:519be643a95c: Fix PgUp/PgDn on layer stack
Summary

The actions activateNextLayer and activatePreviousLayer only activate on nodes which inherit from KisLayer, resulting in incorrect behavior when the active node is a mask.
This patch switches the activation flag for these actions from KisAction::ACTIVE_LAYER to KisAction::ACTIVE_NODE.

Fixes T3888 / https://bugs.kde.org/show_bug.cgi?id=369443

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicholasl updated this revision to Diff 7274.Oct 10 2016, 4:53 PM
nicholasl retitled this revision from to Fix PgUp/PgDn on layer stack.
nicholasl updated this object.
nicholasl edited the test plan for this revision. (Show Details)
nicholasl added a reviewer: Krita: Stable bug fixes.
nicholasl set the repository for this revision to R37 Krita.
nicholasl added a task: T3888: Navigating the layer stack with PgUp/PgDn is broken.
rempt accepted this revision.Oct 10 2016, 7:19 PM
rempt added a reviewer: rempt.
rempt added a subscriber: rempt.

Aw, that was simple! And how did we manage to break that, I wonder.

This revision is now accepted and ready to land.Oct 10 2016, 7:19 PM
Closed by commit R37:519be643a95c: Fix PgUp/PgDn on layer stack (authored by nicholasl). · Explain WhyOct 10 2016, 9:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkrita/krita.action (4 lines)

Diff 7283

View Options

krita/krita.action

Loading...