[KJots] Save on exit
ClosedPublic
Actions

Authored by poboiko on May 14 2020, 6:37 PM.

Details

Reviewers

Commits

Summary

This is follow-up to D29291: [KJots] Provide explicit "Save" action, use standard actions where possible.
When quitting the application, perform a save using the synchronous ItemModifyJob interface.
If the job has failed, show a dialog explaining what can be done to avoid data loss (save it to file using Export menu).

BUG: 296242

Test Plan

Note is now always saved on Ctrl+Q.

Repository

R573 KJots

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 26921
Build 26939: arc lint + arc unit

poboiko requested review of this revision.May 14 2020, 6:37 PM

Minor nitpick, otherwise looks good.

src/kjotswidget.cpp
1238	I would drop the "Akonadi" from the sentence. Akonadi is an implementation detail, it should not be visible anywhere in the UI.
1247	Same here, remove "Akonadi" from the string.

This revision is now accepted and ready to land.May 14 2020, 6:41 PM

I was unsure whether to mention Akonadi here or not. Thanks!

Drop Akonadi mentions, remove stray qDebug line

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	82876	826f291		May 14 2020, 6:37 PM	★	★
Diff 2	82879	826f291	I was unsure whether to mention Akonadi here or not. Thanks!	May 14 2020, 8:35 PM	★	★