Unbreak TestGeoDataCopy
AbandonedPublic

Authored by kossebau on Oct 6 2016, 5:14 PM.

Details

Reviewers
shentey
Group Reviewers
Marble
Summary

b1a507ba5d9e2386bc2dd4b2432569910a5e030e changed
GeoDataPlacemark::coordinate() to use

p()->m_geometry->latLonAltBox().center()

instead of

static_cast<const GeoDataPoint *>( p()->m_geometry )->coordinates()

for GeoDataPoint objects, which changes behaviour a little, as the
returned GeoDataCoordinates no longer has all the details set to the
coordinate of the GeoDataPoint, "detail" and "altitude"
This breaks TestGeoDataCopy, which tests for all those properties.

I am not sure if the properties "detail" and "altitude" are really
expected here, the API documentaion of GeoDataPlacemark::coordinate()
does not explitely define what "coordinates" is about and I have not
tried to track all consumers of the method.

Diff Detail

Repository
R34 Marble
Branch
unbreakTestGeoDataCopy
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau updated this revision to Diff 7163.Oct 6 2016, 5:14 PM
kossebau retitled this revision from to Unbreak TestGeoDataCopy.
kossebau updated this object.
kossebau added reviewers: Marble, shentey.
kossebau updated this revision to Diff 7179.Oct 7 2016, 5:50 AM

update to latest master

kossebau abandoned this revision.Oct 16 2016, 4:33 PM

Obsoleted by recent commits