[KJots] Use KConfigDialog and KConfigXT, fix config desktop file
ClosedPublic

Authored by poboiko on May 12 2020, 1:12 PM.

Details

Summary

This patch does following:

  1. Removes KJotsConfigDlg (child of KCMultiDialog) and changes the code to just use KConfigDialog
  2. Changes names of widgets in .ui-file (prepend kcfg_) to let KConfigXT take care of everything.

(this also fixes invalid signal connections to disable label/spinbox when option AutoSave is not checked)

  1. Changes the layout of .ui-file to QFormLayout instead of QGridLayout with bunch of spacers
  2. Fixes the inconsistency where KJots kontact plugin had name Notes, but its settings plugin used CfgDlgHierarchy=Notebooks

(because of that, KJotsConfigMisc appeared as a top-level Misc page in Kontact KCM, making in unclear which app do these settings belong)

Test Plan
  1. Changes in settings are still saved to the config
  2. Misc page now appears under Notes in Kontact KCM
  3. Triggering the AutoSave checkbox now correctly enables/disables the AutoSaveInterval

Diff Detail

Repository
R573 KJots
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
poboiko created this revision.May 12 2020, 1:12 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 12 2020, 1:12 PM
poboiko requested review of this revision.May 12 2020, 1:12 PM
mlaurent accepted this revision.May 12 2020, 7:53 PM
This revision is now accepted and ready to land.May 12 2020, 7:53 PM
This revision was automatically updated to reflect the committed changes.