Differential D2964

cmake manager: fix incorrect settings import from existing build directory
ClosedPublic
Actions

Authored by antonanikin on Oct 6 2016, 1:33 PM.

Details

Reviewers
apol
Group Reviewers
KDevelop
Commits
R32:81f8d1588457: cmake manager: fix incorrect settings import from existing build directory
R32:17b6499ee581: cmake manager: fix incorrect settings import from existing build directory
Summary

Old version ignores install directory and build type settings when user add existing build directory to project. This incorrect behavior leads in particular to full-rebuild if selected build type (which can be choosen from combo box before build directory selecting) and existing build type (from build directory) are different. The patch fixes this bug by additional parsing of CMakeCache.txt file.

Test Plan

Tested on master branch with different projects and build directories.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
antonanikin updated this revision to Diff 7154.Oct 6 2016, 1:33 PM
antonanikin retitled this revision from to cmake manager: fix incorrect settings import from existing build directory.
antonanikin updated this object.
antonanikin edited the test plan for this revision. (Show Details)
antonanikin added a reviewer: KDevelop.
antonanikin set the repository for this revision to R32 KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 6 2016, 1:33 PM
antonanikin edited the test plan for this revision. (Show Details)Oct 6 2016, 1:34 PM
apol added a subscriber: apol.Oct 6 2016, 7:32 PM

Please revert the coding style changes, they make it quite hard to review the patch.

antonanikin updated this revision to Diff 7174.Oct 7 2016, 12:21 AM

revert coding style changes

apol accepted this revision.Oct 7 2016, 12:26 AM
apol added a reviewer: apol.

Thanks!

This revision is now accepted and ready to land.Oct 7 2016, 12:26 AM
Closed by commit R32:81f8d1588457: cmake manager: fix incorrect settings import from existing build directory (authored by antonanikin). · Explain WhyOct 7 2016, 12:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7175

View Options

projectmanagers/cmake/cmakebuilddirchooser.h

Loading...
View Options

projectmanagers/cmake/cmakebuilddirchooser.cpp

Loading...