Differential D29622

Allow creating Followup reminders through a DBus call to the agent
ClosedPublic
Actions

Authored by dvratil on May 11 2020, 10:36 AM.

Details

Reviewers

mlaurent

Maniphest Tasks

T13172: kdepim-apps-libs cleanup

Commits

R206:05a7f93b3873: Allow creating Followup reminders through a DBus call to the agent

Summary

The idea is for the client code to use this DBus method rather than writing to a shared
config file and triggering reload. This way it will be possible to get rid of the
intermediate libKF5FollowUpReminder library in kdepim-apps-libs.

Diff Detail

Repository

R206 KMail

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dvratil created this revision.May 11 2020, 10:36 AM

Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 11 2020, 10:36 AM

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

dvratil requested review of this revision.May 11 2020, 10:36 AM

Harbormaster completed remote builds in B26688: Diff 82502.May 11 2020, 10:36 AM

@mlaurent ping, I need this as a prerequisite for D29629 :)

mlaurent accepted this revision.May 12 2020, 7:54 PM

This revision is now accepted and ready to land.May 12 2020, 7:54 PM

Closed by commit R206:05a7f93b3873: Allow creating Followup reminders through a DBus call to the agent (authored by dvratil). · Explain WhyMay 13 2020, 7:44 AM

This revision was automatically updated to reflect the committed changes.

dvratil added a task: T13172: kdepim-apps-libs cleanup.May 19 2020, 9:17 AM

Revision Contents
Changeset List

			Path	Packages
M			agents/followupreminderagent/followupreminderagent.h (1 line)
M			agents/followupreminderagent/followupreminderagent.cpp (15 lines)
M			agents/followupreminderagent/followupremindermanager.h (1 line)
M			agents/followupreminderagent/followupremindermanager.cpp (9 lines)
M			agents/followupreminderagent/org.freedesktop.Akonadi.FollowUpReminder.xml (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	82502	750f545		May 11 2020, 10:36 AM	★	★
Diff 2	82710	64e2f08	R206:05a7f93b38732b2ce1282980452a122efbd0834e	May 13 2020, 7:44 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
d2df93a21873	5d7a63447aa3	750f54526452	Daniel Vrátil	Allow creating Followup reminders through a DBus call to the agent (Show More…)	May 11 2020, 10:35 AM