[KJots] Add StandardNoteActionManager
ClosedPublic
Actions

Authored by poboiko on May 8 2020, 4:44 PM.

Details

Reviewers

dvratil

Commits

R573:5ced6ed63668: [KJots] Add StandardNoteActionManager

Summary

This adds a class that stores note-related actions. Currently those are:

It also provides access to Akonadi::StandardActionManager, which allows to reuse the standard actions for:

Book creation (akonadi_collection_create)
Note / Book removal (akonadi_item_delete, akonadi_collection_delete)
Copy link address (akonadi_item_copy, akonadi_collection_copy) - this is slightly buggy, see D29484: [StandardActionManager] Don't add PendingCutRole when copying
...and some other actions like "create resource" in the future

This was written with possible triple-column UI (like KMail / KAddressBook has) in mind, where item / collection views could be separated.

This slightly changes the behavior:

"Delete selection" action (allowed to delete notes and books simultaneously) was removed
"Delete Note / Book" are now disabled if note / book is locked
They also now show confirmation dialog
A slight change in terminology (instead of "Page" I suggest just using "Note"; TODO: need to do it consistently)

Test Plan

Tested changed actions, they seem to be functional

Repository

R573 KJots

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

poboiko requested review of this revision.May 8 2020, 4:44 PM

Nice job, just some suggestions for improvements...

src/noteshared/standardnoteactionmanager.cpp
412	Use `std::unique_ptr` for automatic memory management (or just allocate it on heap), you already initialize it in the constructor anyway.
598	Shouldn't be needed.
src/noteshared/standardnoteactionmanager.h
185	Make it an `std::unique_ptr<Private> const d`, so you don't have to delete it manually.

This revision is now accepted and ready to land.May 8 2020, 8:47 PM

Thanks!

Use unique_ptr, remove moc-file include

const

This revision was automatically updated to reflect the committed changes.

		Path
M		src/CMakeLists.txt (4 lines)
D	M	src/kjotslockjob.h (52 lines)
D	M	src/kjotslockjob.cpp (69 lines)
M		src/kjotspartui.rc (10 lines)
M		src/kjotstreeview.h (13 lines)
M		src/kjotstreeview.cpp (70 lines)
M		src/kjotsui.rc (14 lines)
M		src/kjotswidget.h (15 lines)
M		src/kjotswidget.cpp (320 lines)
M		src/kontact_plugin/kjots_plugin.cpp (2 lines)
M		src/noteshared/CMakeLists.txt (2 lines)
M		src/noteshared/notecreatorandselector.cpp (2 lines)
A	M	src/noteshared/standardnoteactionmanager.h (189 lines)
A	M	src/noteshared/standardnoteactionmanager.cpp (589 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	82291	f629f4a		May 8 2020, 4:44 PM	★	★
Diff 2	82342	f629f4a	Thanks!	May 9 2020, 9:59 AM	★	★
Diff 3	82343	f629f4a	const	May 9 2020, 10:00 AM	★	★
Diff 4	82344	f629f4a	R573:5ced6ed6366886c21b890580ac5654da8e716bed	May 9 2020, 10:00 AM	★	★