Differential D2947

Fix bug 369882 ("Brush property Color: Mix doesnt work right with the default colorspace in 16 Bits")
ClosedPublic
Actions

Authored by nicholasl on Oct 5 2016, 3:01 PM.

Details

Reviewers
rempt
Group Reviewers
Krita: Stable bug fixes
Commits
R37:2503ee390e22: Fix bug 369882 ("Brush property Color: Mix doesnt work right with the default…
Summary

m_cachedBackGroundColor, which is used for mixing, is only set to the actual background color when m_color.colorSpace() != m_foreGroundColor.colorSpace(). In the case of the bug, the colorspaces are equal.

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicholasl updated this revision to Diff 7120.Oct 5 2016, 3:01 PM
nicholasl retitled this revision from to Fix bug 369882 ("Brush property Color: Mix doesnt work right with the default colorspace in 16 Bits").
nicholasl updated this object.
nicholasl edited the test plan for this revision. (Show Details)
nicholasl added a reviewer: Krita: Stable bug fixes.
nicholasl set the repository for this revision to R37 Krita.
rempt accepted this revision.Oct 6 2016, 2:17 PM
rempt added a reviewer: rempt.
rempt added a subscriber: rempt.

Good catch! Have you got commit access? If so, please push.

This revision is now accepted and ready to land.Oct 6 2016, 2:17 PM
nicholasl added a comment.Oct 6 2016, 2:34 PM

I don't have commit access.

rempt added a comment.Oct 6 2016, 2:51 PM

Would you like to get it? If so, please use me as a reference. See https://community.kde.org/Infrastructure/Get_a_Developer_Account

Closed by commit R37:2503ee390e22: Fix bug 369882 ("Brush property Color: Mix doesnt work right with the default… (authored by nicholasl). · Explain WhyOct 8 2016, 9:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7211

View Options

plugins/paintops/libpaintop/kis_color_source.cpp

Loading...