Fix broken search in Documentation View
ClosedPublic

Authored by antonanikin on Oct 4 2016, 4:20 PM.

Details

Summary

The patch fixes broken search in Documentation View. Steps to reproduce:

  1. Open Documentation View
  2. Select CMake documentation
  3. Type in the search line edit "set_"
  4. Internal completer produce list of appropriate documentation items
  5. With arrrow keys select "set_property" item (2nd) and press Enter
  6. You will see "set_directory_properties" page - 1st element from completer list.

Such broken search happens every time - we will see the only first element from completer list.

New version fixes this annoying bug.

Diff Detail

Repository
R33 KDevPlatform
Lint
Lint Skipped
Unit
Unit Tests Skipped
antonanikin updated this revision to Diff 7097.Oct 4 2016, 4:20 PM
antonanikin retitled this revision from to Fix broken search in Documentation View; code cleanup.
antonanikin updated this object.
antonanikin edited the test plan for this revision. (Show Details)
antonanikin added a reviewer: KDevelop.
antonanikin set the repository for this revision to R33 KDevPlatform.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 4 2016, 4:20 PM
antonanikin updated this revision to Diff 7177.Oct 7 2016, 4:43 AM
antonanikin retitled this revision from Fix broken search in Documentation View; code cleanup to Fix broken search in Documentation View.

simplified version, only bug fix

kfunk accepted this revision.Oct 12 2016, 7:20 PM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

Wow, I'm surprised noone noticed this before (I haven't seen a bug report about this yet).

To 5.0 branch please

This revision is now accepted and ready to land.Oct 12 2016, 7:20 PM
This revision was automatically updated to reflect the committed changes.