Fix broken search in Documentation View
ClosedPublic
Actions

Authored by antonanikin on Oct 4 2016, 4:20 PM.

Details

Reviewers

kfunk

Group Reviewers

KDevelop

Commits

Summary

The patch fixes broken search in Documentation View. Steps to reproduce:

Open Documentation View
Select CMake documentation
Type in the search line edit "set_"
Internal completer produce list of appropriate documentation items
With arrrow keys select "set_property" item (2nd) and press Enter
You will see "set_directory_properties" page - 1st element from completer list.

Such broken search happens every time - we will see the only first element from completer list.

New version fixes this annoying bug.

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

antonanikin retitled this revision from to Fix broken search in Documentation View; code cleanup.

antonanikin updated this object.

antonanikin edited the test plan for this revision. (Show Details)

antonanikin added a reviewer: KDevelop.

antonanikin set the repository for this revision to R33 KDevPlatform.

simplified version, only bug fix

Wow, I'm surprised noone noticed this before (I haven't seen a bug report about this yet).

To 5.0 branch please

This revision is now accepted and ready to land.Oct 12 2016, 7:20 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			documentation/documentationview.h (3 lines)
M			documentation/documentationview.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	7097			Oct 4 2016, 4:06 PM	★	★
Diff 2	7177			Oct 7 2016, 4:42 AM	★	★
Diff 3	7365	21d0a97	rKDEVPLATFORM06022811cacbd0bca68cf15cfa22bda02ac88514	Oct 13 2016, 1:37 AM	★	★