[KJots] Add support for headings
ClosedPublic

Authored by poboiko on Apr 30 2020, 3:01 PM.

Details

Summary

This patch adds support for headings, introduced for underlying KRichTextEdit in D28854: [KRichTextWidget] Add support for headings.
It adds relevant actions to toolbars & menu.
This also increases the required KF5 version to (not yet released) 5.70.

Slighly overlaps with D29291: [KJots] Provide explicit "Save" action, use standard actions where possible (which increases the version in .rc-file)

CCBUG: 230317

Test Plan

it compiles, actions are added (and functional)

Diff Detail

Repository
R573 KJots
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
poboiko requested review of this revision.Apr 30 2020, 3:01 PM
poboiko created this revision.
mlaurent requested changes to this revision.May 1 2020, 7:42 AM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
src/kjotspartui.rc
2

Increase version here

src/kjotsui.rc
2

Increase version here

This revision now requires changes to proceed.May 1 2020, 7:42 AM
poboiko edited the summary of this revision. (Show Details)May 2 2020, 10:08 AM

@mlaurent: There's just another subsequent patch that waits for review, D29291: [KJots] Provide explicit "Save" action, use standard actions where possible, which also touches those actions. I thought it's only important that this version increases between releases, and it would be sufficient to increase the version only once there (just so I won't have to think which patch lands first, and then rebase another one with yet another version change, etc).
Or should I actually do it in every commit that touches XMLGui-files?

By default we increase each time that we change this file.
But if you commit this two patchs in same time it(s not the problem :)

This revision was not accepted when it landed; it landed in state Needs Revision.May 9 2020, 10:05 AM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: KDE PIM. · View Herald TranscriptMay 9 2020, 10:05 AM