Class Browser list expanding during search; add delayed filtering
ClosedPublic

Authored by antonanikin on Oct 4 2016, 10:16 AM.

Details

Summary

This patch provides expanding of Class Browser list during search. Old version collapses classes list by default and don't expand it during search, user must do it manually, which is annoying action.

The patch also adds delayed filtering (500 ms. after the end of typing) which improves performance for big projects (we shouldn't update the filter immediately after the text is changed).

Old behavior:

  1. Open Class Browser - list is collapsed by default
  2. Type something in search line
  3. Classes list is still collapsed

New behavior:

  1. Open Class Browser - list is collapsed by default
  2. Type something in search line
  3. Classes list is expanded (after small delay) which allows to see results without additional actions
  4. Clear search line - classes list is collapsed again.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
antonanikin updated this revision to Diff 7078.Oct 4 2016, 10:16 AM
antonanikin retitled this revision from to Class Browser list expanding during search.
antonanikin updated this object.
antonanikin edited the test plan for this revision. (Show Details)
antonanikin added a reviewer: KDevelop.
antonanikin set the repository for this revision to R33 KDevPlatform.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptOct 4 2016, 10:16 AM
kfunk accepted this revision.Oct 12 2016, 7:37 PM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.

Works fine for me. It's still reasonably fast, even with qtbase.git loaded in KDevelop.

One thing to consider: We shouldn't update the filter each time the text is changed (bad performance for big projects). We should delay updating the filter a bit.

Here's some info how to do it: https://wiki.qt.io/Delay_action_to_wait_for_user_interaction

Some more remarks:

  • To 5.0 branch please
  • Please separate style cleanups from the actual behavior change
  • Please be more verbose in the commit message, explain before/after situation
This revision is now accepted and ready to land.Oct 12 2016, 7:37 PM
antonanikin updated this revision to Diff 7371.Oct 13 2016, 8:21 AM
antonanikin edited edge metadata.
antonanikin retitled this revision from Class Browser list expanding during search to Class Browser list expanding during search; add delayed filtering.Oct 13 2016, 8:31 AM
antonanikin updated this object.
This revision was automatically updated to reflect the committed changes.