Differential D29287

[KJots] New signal / slot API & minor cleanup
ClosedPublic
Actions

Authored by poboiko on Apr 29 2020, 7:37 PM.

Details

Reviewers
dvratil
Commits
R573:50f0085718dc: [KJots] New signal / slot API & minor cleanup
Summary

This patch contans no functional change, just some code cleanup

Test Plan

make

Diff Detail

Repository
R573 KJots
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
poboiko created this revision.Apr 29 2020, 7:37 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 29 2020, 7:37 PM
poboiko requested review of this revision.Apr 29 2020, 7:37 PM
poboiko updated this revision to Diff 81620.Apr 30 2020, 6:46 PM

Use QStandardPaths::writableLocation for bookmarks file
Remove Q_SLOT from canGo

dvratil accepted this revision.May 2 2020, 9:22 PM

Looks good, just one nit pick - you can fix it before committing, I don't need to review it again.

src/noteshared/localresourcecreator.cpp
49–51

I'd make this const bool

This revision is now accepted and ready to land.May 2 2020, 9:22 PM
poboiko updated this revision to Diff 81782.May 3 2020, 9:40 AM

const'ify

Closed by commit R573:50f0085718dc: [KJots] New signal / slot API & minor cleanup (authored by poboiko). · Explain WhyMay 3 2020, 9:40 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 11 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 81783

View Options

src/noteshared/localresourcecreator.cpp

Loading...