Less segfaulty PageRouterAttached
ClosedPublic

Authored by cblack on Apr 28 2020, 5:39 PM.

Details

Summary
  • PageRouterAttached will have its router set when the PageRouter creates an object for a route instead of relying on tree climbing
  • All PageRouterAttached methods now check for null
Test Plan

make test

Diff Detail

Repository
R169 Kirigami
Branch
cblack/less-segfaulty-pagerouter (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26052
Build 26070: arc lint + arc unit
cblack created this revision.Apr 28 2020, 5:39 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptApr 28 2020, 5:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Apr 28 2020, 5:39 PM
mart accepted this revision.Apr 28 2020, 6:25 PM
This revision is now accepted and ready to land.Apr 28 2020, 6:25 PM
cblack updated this revision to Diff 81466.Apr 28 2020, 7:29 PM

Parent climbing

This revision was automatically updated to reflect the committed changes.