Add setDefaultProfile() to ViewManager
ClosedPublic
Actions

Authored by z3ntu on Apr 27 2020, 5:36 PM.

Details

Reviewers

None

Group Reviewers

Konsole

Commits

Summary

This allows the user to set the default Konsole profile via D-Bus.

Test Plan

Open yakuake
Open d-feet on Session Bus org.kde.yakuake -> /Windows/1 -> org.kde.konsole.Window
Have two Yakuake profiles (mine are called 'Dark' and 'Light')
defaultProfile() returns 'Dark'
setDefaultProfile('Light')
defaultProfile() returns 'Light' and opening a new tab in Yakuake shows that the 'Light' profile is active

Repository

R319 Konsole

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: konsole-devel. · View Herald Transcript

z3ntu requested review of this revision.Apr 27 2020, 5:36 PM

Quick other question: This repo doesn't contain a .arcconfig file yet, should I submit a patch to add it?

And also the code is mostly copied from Session::setProfile

All of KDE is moving to gitlab - please add a merge request there https://invent.kde.org/kde/konsole/-/merge_requests

I can still respond here as long as phabiciator is still up if you can't do a merge request.

Thanks it looks fine. I'll commit shortly.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 30 2020, 2:27 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/ViewManager.h (4 lines)
M			src/ViewManager.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	81373	028a31e		Apr 27 2020, 5:36 PM	★	★
Diff 2	81589	a1b7807	R319:eaef61e1c4174c34c76f20cd1e662b63f18436d7	Apr 30 2020, 2:27 PM	★	★