Differential D29165

[System Monitor] Fix update interval setting
AbandonedPublic
Actions

Authored by ksmanis on Apr 24 2020, 9:07 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

The update interval setting for the system monitor applets seems to be borked right now, as a result of a missing reference and an i18ncp call that receives a decimal argument.

Test Plan

Current behavior:

Patched behavior:

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25873
Build 25891: arc lint + arc unit
ksmanis created this revision.Apr 24 2020, 9:07 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 24 2020, 9:07 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ksmanis requested review of this revision.Apr 24 2020, 9:07 PM
ksmanis edited the summary of this revision. (Show Details)Apr 24 2020, 9:09 PM
ksmanis edited the test plan for this revision. (Show Details)
ksmanis added a reviewer: Plasma.
ksmanis added a comment.EditedApr 24 2020, 9:12 PM

I am not sure what the proper solution for the i18ncp call is, given that the argument is decimal. Someone more knowledgeable should probably chime in.

ksmanis updated this revision to Diff 81160.Apr 25 2020, 10:19 AM
  • Make update interval spinbox locale-aware
ksmanis abandoned this revision.May 17 2020, 10:34 AM

Revision Contents
Changeset List

Diff 81160

View Options

applets/systemmonitor/common/contents/ui/ConfigGeneral.qml

Loading...