Clean up font size drop-down oddities with MVC pattern
AcceptedPublic

Authored by herbmillerjr on Apr 2 2020, 3:55 PM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Summary

Updating the font size drop-downs in the main window and the tag editor was being handled manually and had some odd behavior such as point sizes changing to 10 when selected, preventing that size from ever being selected again. Changing the combo box to follow Qt's model/view approach seems to have addressed much of this.

The handling of the (Default) label in the combo box was changed to agree with the MVC pattern and completely by accident made the appearance more consistent with the other fields in the tag editor that have default values. Qt's default Font() assigns a default size by pixel on Linux, so no default point size is available, so a reasonable default of 10 points was chosen.

Test Plan

Valid custom size
Invalid custom size
New style default tag size
Non-default tag size

Diff Detail

Repository
R1050 BasKet
Lint
Lint Skipped
Unit
Unit Tests Skipped
herbmillerjr requested review of this revision.Apr 2 2020, 3:55 PM
herbmillerjr created this revision.

Example of issue with font sizes disabling themselves.

herbmillerjr edited the test plan for this revision. (Show Details)Apr 2 2020, 4:13 PM
ndavis added a subscriber: ndavis.Apr 2 2020, 4:15 PM
This comment was removed by ndavis.
ndavis accepted this revision.Apr 2 2020, 4:21 PM

Its always fun to discover fixes by accident.

This revision is now accepted and ready to land.Apr 2 2020, 4:21 PM