[controls/formlayout] Don't attempt to reset implicitWidth
ClosedPublic

Authored by cblack on Mar 26 2020, 7:47 PM.

Details

Summary

When a FormLayout is in wide mode, it attempts to
reset the implicitWidth of a GridLayout by assigning undefined to it.
This doesn't work because:

  1. Layouts provide their own implicit width
  2. You can't reset an implicit size with undefined, hence the error messages obtained from trying to do so

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Mar 26 2020, 7:47 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptMar 26 2020, 7:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Mar 26 2020, 7:47 PM
ngraham accepted this revision.Mar 26 2020, 7:51 PM
This revision is now accepted and ready to land.Mar 26 2020, 7:51 PM
This revision was automatically updated to reflect the committed changes.