Differential D28190

fix: more clear message for the undosend event
ClosedPublic
Actions

Authored by ltoscano on Mar 21 2020, 7:03 PM.

Details

Reviewers
mlaurent
Commits
R206:9b39f7529019: fix: more clear message for the undosend event
Summary

Improve the description of the message associated
with the undosend event.

Diff Detail

Repository
R206 KMail
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ltoscano created this revision.Mar 21 2020, 7:03 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 21 2020, 7:03 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
ltoscano requested review of this revision.Mar 21 2020, 7:03 PM
ltoscano added a comment.Mar 21 2020, 7:03 PM

I'm not totally sure that the replacement string captures the intended meaning, hence the review.

mlaurent added a subscriber: mlaurent.Mar 21 2020, 8:10 PM

nope.
This notification is showing when we send an email, so we have a button for undo sending
=> it's not "was cancel" but 'can cancel"

mlaurent requested changes to this revision.Mar 21 2020, 8:10 PM
This revision now requires changes to proceed.Mar 21 2020, 8:10 PM
ltoscano updated this revision to Diff 78236.Mar 22 2020, 4:19 PM

Try to address the comments and to find an even more precise
description after rechecking the behavior.

mlaurent accepted this revision.Mar 23 2020, 7:18 AM

It seems better.
Thanks

This revision is now accepted and ready to land.Mar 23 2020, 7:18 AM
Closed by commit R206:9b39f7529019: fix: more clear message for the undosend event (authored by ltoscano). · Explain WhyMar 25 2020, 9:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/data/kmail2.notifyrc (25 lines)

Diff 78504

View Options

src/data/kmail2.notifyrc

Loading...