If user tries to modify a contact that has just been created, the modify job returns 404.
Although remoteId gets updated by changeCommitted, the UID inside Addressee doesn't.
We need to update the payload explicitly, in order to resolve the confusion
This patch adds an ItemModifyJob which does precisely that.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 24100 | |
| Build 24118: arc lint + arc unit |
| resources/google/contacts/contactsresource.cpp | ||
|---|---|---|
| 527 | This should not be needed: the call to Akonadi::ResourceBase::changeCommitted() does internally call ItemModifyJob for the item in order to update the remoteid... | |
Hmm, that's weird.
I've looked into CalendarResource (say, slotCreateJobFinished) and the code there explicitly calls ItemModifyJob too.
Here's the debug output without this change:
org.kde.kgapi: ("http://www.google.com/m8/feeds/groups/EMAIL%40gmail.com/base/6")
org.kde.kgapi: Queued QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full")
org.kde.kgapi: KGAPI2::ContactCreateJob(0x556e98b54020) Dispatching request to QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full")
org.kde.pim.akonadicore: Deleting items from the akonadi database failed: "No items found"
org.kde.kgapi: Received reply from QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full?prettyPrint=false")
org.kde.kgapi: Status code: 201
org.kde.pim.akonadicore: Deleting items from the akonadi database failed: "No items found"
org.kde.kgapi: ("http://www.google.com/m8/feeds/groups/EMAIL%40gmail.com/base/6")
org.kde.kgapi: Queued QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full/843a45f9-b479-46c2-bb4a-607d438e92e9")
org.kde.kgapi: KGAPI2::ContactModifyJob(0x556e98b72920) Dispatching request to QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full/843a45f9-b479-46c2-bb4a-607d438e92e9")
org.kde.pim.akonadicore: Deleting items from the akonadi database failed: "No items found"
org.kde.kgapi: Received reply from QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full/843a45f9-b479-46c2-bb4a-607d438e92e9?prettyPrint=false")
org.kde.kgapi: Status code: 404
org.kde.kgapi: Requested resource does not exist
org.kde.kgapi: Queued QUrl("https://www.google.com/m8/feeds/photos/media/EMAIL@gmail.com/843a45f9-b479-46c2-bb4a-607d438e92e9")
org.kde.kgapi: KGAPI2::ContactModifyJob(0x556e98b72920) Dispatching request to QUrl("https://www.google.com/m8/feeds/photos/media/EMAIL@gmail.com/843a45f9-b479-46c2-bb4a-607d438e92e9")
org.kde.kgapi: Received reply from QUrl("https://www.google.com/m8/feeds/photos/media/EMAIL@gmail.com/843a45f9-b479-46c2-bb4a-607d438e92e9")
org.kde.kgapi: Status code: 404
org.kde.kgapi: Requested resource does not existThe ID for newly created contact is 843a45f9-b479-46c2-bb4a-607d438e92e9, which is not right (the right one is 41c9b4289fd31e5).
Although you seem to be correct, I've checked AkonadiConsole and the remoteId there is correct. There is indeed an ItemModifyJob in the job tracker.
With the patch, however, the logs show following:
org.kde.kgapi: ("http://www.google.com/m8/feeds/groups/EMAIL%40gmail.com/base/6")
org.kde.kgapi: Queued QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full")
org.kde.kgapi: KGAPI2::ContactCreateJob(0x55c3a22c3590) Dispatching request to QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full")
org.kde.pim.akonadicore: Deleting items from the akonadi database failed: "No items found"
org.kde.kgapi: Received reply from QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full?prettyPrint=false")
org.kde.kgapi: Status code: 201
org.kde.pim.akonadicore: Deleting items from the akonadi database failed: "No items found"
org.kde.kgapi: ("http://www.google.com/m8/feeds/groups/EMAIL%40gmail.com/base/6")
org.kde.kgapi: Queued QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full/2886fa4b0a791ec9")
org.kde.kgapi: KGAPI2::ContactModifyJob(0x55c3a1df1e40) Dispatching request to QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full/2886fa4b0a791ec9")
org.kde.pim.akonadicore: Deleting items from the akonadi database failed: "No items found"
org.kde.kgapi: Received reply from QUrl("https://www.google.com/m8/feeds/contacts/EMAIL@gmail.com/full/2886fa4b0a791ec9?prettyPrint=false")
org.kde.kgapi: Status code: 200
org.kde.kgapi: Queued QUrl("https://www.google.com/m8/feeds/photos/media/EMAIL@gmail.com/2886fa4b0a791ec9")
org.kde.kgapi: 1 requests in requestQueue.
org.kde.kgapi: KGAPI2::ContactModifyJob(0x55c3a1df1e40) Dispatching request to QUrl("https://www.google.com/m8/feeds/photos/media/EMAIL@gmail.com/2886fa4b0a791ec9")
org.kde.kgapi: Received reply from QUrl("https://www.google.com/m8/feeds/photos/media/EMAIL@gmail.com/2886fa4b0a791ec9")
org.kde.kgapi: Status code: 200i.e. everything works just fine. Any ideas?
OK, it might actually be a KAddressBook issue. If I:
then everything works like charm. But without updating , KAB gets that weird contact ID god knows from where, and tries to change it.
There seems to be a confusion between remoteId and the vCard UID stored in the contact payload. The ItemModifyJob in changeComitted() only updates the Item's remoteId, it does not update the payload - the contact keeps the default UID generated by KAddressBook. The event returned by Google contains UID generated by Google, so we end up with a conflict.
So your initial patch was, in fact, correct. Please just add a comment explaining that we need to update the vCard UID stored in the payload.