[calendar] Implement SyncToken for Calendar service
ClosedPublic
Actions

Authored by poboiko on Mar 20 2020, 1:43 PM.

Details

Reviewers

Commits

R477:e999f481773b: [calendar] Implement SyncToken for Calendar service

Summary

This is an implementation of a syncToken Google API feature (see T8376: [Calendar] Implement support for syncToken, and
https://developers.google.com/calendar/v3/reference/events/list) which is a
native way to perform incremental updates.

When EventFetchJob is created, we can provide it with a token by calling
job->setSyncToken(token), which will be used as a parameter for fetching.
Note: some of the parameters are incompatible with syncToken (timeMin,
timeMax, updatedMin, see API link above), so if token is provided, those
parameters get ignored.

When the job is finished, the next sync token can be obtained via
job->syncToken(). This token then can be used for the next EventFetchJob.

Test Plan

Create an EventFetchJob with no syncToken
When job is finished, fetch its syncToken
Create a new job, using previous syncToken
Only incremental changes are obtained

Diff Detail

Repository

R477 KGAPI Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

poboiko created this revision.Mar 20 2020, 1:43 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 20 2020, 1:43 PM

poboiko requested review of this revision.Mar 20 2020, 1:43 PM

Harbormaster completed remote builds in B23984: Diff 78093.Mar 20 2020, 1:43 PM

Nicely done! One minor nitpick, please fix it before merging.

src/calendar/eventfetchjob.cpp
188	Use `d->syncToken.clear()`

Use clear() instead

Harbormaster completed remote builds in B23985: Diff 78096.Mar 20 2020, 2:28 PM

poboiko marked an inline comment as done.Mar 20 2020, 2:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 20 2020, 2:30 PM

Closed by commit R477:e999f481773b: [calendar] Implement SyncToken for Calendar service (authored by poboiko). · Explain Why

This revision was automatically updated to reflect the committed changes.

poboiko mentioned this in T8376: [Calendar] Implement support for syncToken.Apr 21 2020, 10:34 AM

Revision Contents
Changeset List

			Path	Packages
M			src/calendar/calendarservice.cpp (4 lines)
M			src/calendar/eventfetchjob.h (22 lines)
M			src/calendar/eventfetchjob.cpp (35 lines)
M			src/core/types.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	78093	c31d9a7		Mar 20 2020, 1:43 PM	★	★
Diff 2	78096	c31d9a7	Use `clear()` instead	Mar 20 2020, 2:28 PM	★	★
Diff 3	78097	7f7d461	R477:e999f481773b0d638e3e347ae23fc815fcb22a39	Mar 20 2020, 2:30 PM	★	★