| dvratil |
| KDE PIM: KMail |
In KMail, the following menu options did not have icons:
This commit adds relevant icons for these.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Thanks a lot for the changes. I suggested some alternatives, you can use a tool called "Cuttlefish" to preview the icons, if you don't know it yet. It's better to focus on the name of the icon rather than what the icon looks like, because with other icon themes the icons may look differently and may not match the intention as much as Breeze does.
| src/kmmainwidget.cpp | ||
|---|---|---|
| 3335 | How about dialog-filters? | |
| 3346 | I think list-resource-add would be a better icon for this. | |
| 3456 | Alternatively, go-jump icon might be a good choice. | |
Also, I had an issue using Cuttlefish: Many icons weren't there at all in my installed Cuttlefish app (including dialog-filters, list-resource-add, go-jump).
Had to use them in the code, and then I was able to see them in the re-built KMail.
plasma-sdk version seems to be fine too. apt show plasma-sdk gives me:
Version: 4:5.16.5-0ubuntu1
Using Ubuntu 19.10
Interesting, maybe some problem with icon cache?
Anyway, thanks a lot for the patch. I assume you don't have commit access yet, so I'll land the patch for you.