Rotate Grouping triangle for plasma indicator if revered option is enabled
Needs ReviewPublic

Authored by mbehrendt on Mar 8 2020, 11:35 PM.

Details

Reviewers
mvourlakos
Summary

The triangle indicating window grouping would not move to the other side.
Like for the BackLayer this is done for the corresponding part of the FrontLayer

Diff Detail

Repository
R878 Latte Dock
Lint
Lint Skipped
Unit
Unit Tests Skipped
mbehrendt created this revision.Mar 8 2020, 11:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 8 2020, 11:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mbehrendt requested review of this revision.Mar 8 2020, 11:35 PM

I think it is better to have an option for this in order to not be applied always when the user reverses the indicator..

And also are you sure that this way the growing circle animation of the indicator is still working correctly?

I think it is better to have an option for this in order to not be applied always when the user reverses the indicator..

And also are you sure that this way the growing circle animation of the indicator is still working correctly?

I am not sure if an option makes sense here as the group triangle looks kind of broken when reversed

Circle animation still works

The gap you see comes from the specific plasma theme, so this is plasma theme responsibility. That specific theme probably has that gap in its tasks svg.

Having an option means that the user can always disable/enable that specific functionality if a plasma theme breaks the experience.

Okay. I just tested with other themes.
Was so used to Materia that I forgot about them.
Yeah an option would make sense then.
I'd like to look into this but that will probably take some time.

no prob, take your time...