[resources/maildir] Don't create junk files
ClosedPublic

Authored by poboiko on Mar 6 2020, 10:37 PM.

Details

Summary

As user types path inside configuration dialog, it gets checked to display
the comment whether it's a valid maildir or not. Under the hood, it calls
maildir.isValid(createMissingFolders=false). There was a codepath, however,
where createMissingFolders is not provided (and the default value is true),
thus creating cur/new/tmp folders all over the place as user types the path.

Test Plan
  1. Try to create maildir inside /tmp/dummy
  2. Observe cur/new/tmp folders being created everywhere inside /tmp/*
  3. After applying the patch, they don't

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
poboiko created this revision.Mar 6 2020, 10:37 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 6 2020, 10:37 PM
poboiko requested review of this revision.Mar 6 2020, 10:37 PM
dvratil accepted this revision.Mar 17 2020, 1:10 PM

Nice catch!

This revision is now accepted and ready to land.Mar 17 2020, 1:10 PM
This revision was automatically updated to reflect the committed changes.