Differential D27825

Do not use AUTOUIC, but ki18n_wrap_ui, as needed to integrate with ki18n
ClosedPublic
Actions

Authored by kossebau on Mar 4 2020, 9:59 AM.

Details

Reviewers
mreeves
Commits
R983:338339018e13: Do not use AUTOUIC, but ki18n_wrap_ui, as needed to integrate with ki18n
R983:d531f3416cb7: Do not use AUTOUIC, but ki18n_wrap_ui, as needed to integrate with ki18n
Summary

Currently makes no difference as there are no translated strings yet
in the only UI file existing so far.
But can be a trap in the future, so prevent falling into that.

Diff Detail

Repository
R983 KDiff3
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau requested review of this revision.Mar 4 2020, 9:59 AM
kossebau created this revision.
mreeves accepted this revision.Mar 5 2020, 3:06 AM

Word of warning 'arch land' will not work for this project as it is on gitlab see D26064 for instructions.

This revision is now accepted and ready to land.Mar 5 2020, 3:06 AM
kossebau added a comment.Mar 5 2020, 1:34 PM

Oh, somehow searching kdiff3 on invent.kde.org had failed for me, that's why i went for phabricator, trying again I now see it. Okay

(BTW, arc land still works. but one has to have in their local git config the remote repo url configured to match the invent git repo, not the git.kde.org one. The latter though is what everyone has using the "kde:" git shortcut usually, thus running into arc land not working)

Closed by commit R983:d531f3416cb7: Do not use AUTOUIC, but ki18n_wrap_ui, as needed to integrate with ki18n (authored by kossebau). · Explain WhyMar 5 2020, 1:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (1 line)
Msrc/CMakeLists.txt (4 lines)

Diff 77021

View Options

CMakeLists.txt

Loading...
View Options

src/CMakeLists.txt

Loading...