[resources/ews] Save password to wallet
ClosedPublic

Authored by poboiko on Mar 3 2020, 8:52 PM.

Details

Summary

Seems like the password entered via the UI actually never gets saved anywhere.
Just do it explicitly.

BUG: 393002
CCBUG: 390798
CCBUG: 402780
CCBUG: 414789

Test Plan
  1. Try to setup EWS account using autodiscovery, using Username/Password auth
  2. Set Username, Password, hit "Try connect" -> it works fine
  3. Hit "OK" -> observe "Authentication failure" resource error
  4. Browse akonadi-ews via KWalletManager -> it's empty
  5. Apply the patch, repeat 1-4 - authentication succeeds, password entry inside wallet appears

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
poboiko created this revision.Mar 3 2020, 8:52 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 3 2020, 8:52 PM
poboiko requested review of this revision.Mar 3 2020, 8:52 PM

I don't really know what I'm doing here, I was just poking around trying to figure out why I wasn't able to authenticate to EWS :)

The symptoms I experienced looked quite like ones that I've seen inside bugreports I've CC'd, but I'm not entirely sure it fixes all of them (that's why its CCBUG).
I just didn't try to compare all the logs, etc with mine.

dvratil accepted this revision.Mar 17 2020, 1:18 PM

Looks OK to me. Thanks for the fix!

This revision is now accepted and ready to land.Mar 17 2020, 1:18 PM
This revision was automatically updated to reflect the committed changes.