Differential D27673

[applets/notes] Fix drag&drop links and cursor shape regression
ClosedPublic
Actions

Authored by luca on Feb 26 2020, 11:29 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R114:b03539a0d8d3: [applets/notes] Fix drag&drop links and cursor shape regression
Summary

Restore the possibility to drag and drop the links from browser, and the cursor shape now changes on links.

BUG: 417953
FIXED-IN: 5.18.3

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
luca requested review of this revision.Feb 26 2020, 11:29 AM
luca created this revision.
ngraham added a subscriber: ngraham.Feb 26 2020, 3:09 PM

Nice job. Just two very minor comments:

applets/notes/package/contents/ui/main.qml
341

Remove the spaces on this line

346

Remove trailing whitespace

luca updated this revision to Diff 76473.Feb 26 2020, 4:09 PM

Spaces removed

luca marked 2 inline comments as done.Feb 26 2020, 4:09 PM
ngraham accepted this revision.Feb 26 2020, 4:28 PM
This revision is now accepted and ready to land.Feb 26 2020, 4:28 PM
ngraham retitled this revision from [applets/notes] drag&drop links and cursor shape regression to [applets/notes] Fix drag&drop links and cursor shape regression .Feb 26 2020, 4:28 PM
ngraham edited the summary of this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
Closed by commit R114:b03539a0d8d3: [applets/notes] Fix drag&drop links and cursor shape regression (authored by Luca Pedrielli <luca.pedrielli@gmail.com>, committed by ngraham). · Explain WhyFeb 26 2020, 6:17 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptFeb 26 2020, 6:17 PM
ngraham added a comment.Feb 26 2020, 6:19 PM

Nice job, and nice first patch! May it be the first of many. :)

Revision Contents
Changeset List

Diff 76489

View Options

applets/notes/package/contents/ui/main.qml

Loading...