| sandroandrade |
Use of the FluidSynth Library to set the pitch.
The documentations does mention that: 0 << pitch << 1024 * 16 - 1
The pitch slider has been set from 0 to 16
Changing the pitch has immediate effect.
The tempo has only been reactivated, it does work but needs the current question to be stopped() and played() again.
| Lint Skipped |
| Unit Tests Skipped |
Volume, change volume from 0 to 127 using the slider.
fluid_synth_cc(m_synth, 1, 7, m_volume) // change the volume (command 7), on the channel 1
Hi,
Could you please make the required changes?
Thanks for your patch :)
| src/app/qml/midiplayer/MidiPlayer.qml | ||
|---|---|---|
| 124 | You'd better keep those from -12 (one octave below) to 12 (one octave above), since it's somehow implementation independent. And then make the required calculations in fluidsynth backend implementation. | |
| 138 | Same here. Let's keep the volume slider ranging from 50% to 200% (default value 100%) and make the needed calculations in the fluidsynth backend. | |
I've followed your recommendations.
Sliders have been set to:
The corresponding tunning for the fluidsynth lib are done in the setters.
Hi,
Thanks again for your patch. It seems the pitch change implementation still misses something, though. Fluidsynth documentation says:
MIDI pitch bend value (0-16383 with 8192 being center)
However, the default configuration for pitch bend is to increase/decrease two semitones. You need to send a configuration MIDI event ("Controller Event") to set the value of the Data Entry MSB for pitch bends. That must be done only once, at sound backend initialization.
Check the section "Pitch Bend "Events" and the Data Entry MSB Controller" at:
http://www.infocellar.com/sound/midi/pitch-bends.htm
Actually, there is a much simpler implementation, with no need for using pitch bend events.
Just add the pitch drift in FluidSynthSoundBackend::prepareFromExerciseOptions. Something like:
...
appendEvent(1, chosenRootNote + m_pitch, 127, 1000*(60.0/m_tempo));
...
foreach ...
appendEvent(1, chosenRootNote + additionalNote.toInt() + m_pitch, 127, ((m_playMode == "scale") ? 1000:4000)*(60.0/m_tempo));
If we do so, we cannot change the pitch during an exercise. Should I use fluid_synth_pitch_bend with the Data Entry MSB Controller instead?
| src/app/qml/midiplayer/MidiPlayer.qml | ||
|---|---|---|
| 124 | thank you for the review, I will edit them this week-end. | |
The documentation advise on setting Registered Param LSB and Registered Param MSB to 0.
The Data Entry MSB has been set to 14.
Those changes are done in the constructor of FluidSynthSoundBackend right after the definition of m_synth.
My ears say some weird things are still happening :)
Could you try to figure out what is happening? I can give you some help if you find it hard to solve.
Thanks,