Differential D27139

Add account overview widget
ClosedPublic
Actions

Authored by olivierjg on Feb 3 2020, 6:51 PM.

Details

Reviewers
dfaure
mlaurent
Commits
R865:76a8e85dd343: Add account overview widget

Diff Detail

Repository
R865 Ruqola
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22026
Build 22044: arc lint + arc unit
olivierjg requested review of this revision.Feb 3 2020, 6:51 PM
olivierjg created this revision.
olivierjg updated this revision to Diff 74946.Feb 3 2020, 7:03 PM

Add copyright header, fix status text

dfaure added inline comments.Feb 3 2020, 7:03 PM
src/widgets/misc/accountsoverviewwidget.cpp
116

Use i18n() in KDE apps :-)

(repeats below)

118

Concatenation of IILEs, interesting syntax :)

169

unused param parent, no? (missing : QWidget(parent))

olivierjg updated this revision to Diff 74947.Feb 3 2020, 7:11 PM

i18n, unused param, clarity

olivierjg updated this revision to Diff 74949.Feb 3 2020, 7:20 PM

Make it clear which account is current

olivierjg marked 3 inline comments as done.Feb 3 2020, 7:22 PM
dfaure added inline comments.Feb 3 2020, 7:26 PM
src/widgets/misc/accountsoverviewwidget.h
3

No email address?

34

explicit

olivierjg updated this revision to Diff 74951.Feb 3 2020, 7:35 PM

Add email address, explicit

olivierjg marked 2 inline comments as done.Feb 3 2020, 7:42 PM
olivierjg updated this revision to Diff 74952.Feb 3 2020, 7:47 PM

updateGeometry when updating notification state

dfaure accepted this revision.Feb 3 2020, 9:19 PM
This revision is now accepted and ready to land.Feb 3 2020, 9:19 PM
olivierjg closed this revision.Feb 3 2020, 9:51 PM

Revision Contents
Changeset List

Diff 74952

View Options

src/widgets/CMakeLists.txt

Loading...
View Options

src/widgets/misc/accountsoverviewwidget.h

Loading...
View Options

src/widgets/misc/accountsoverviewwidget.cpp

Loading...
View Options

src/widgets/ruqolamainwindow.cpp

Loading...